Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2488 - CSharp | Add EnumMember Attribute if CodeEnumOption.Serializa… #2493

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

vadrsa
Copy link

@vadrsa vadrsa commented Mar 30, 2023

…tionName is different from CodeEnumOption.Name

Is a 'sub-fix' for #2488

@vadrsa
Copy link
Author

vadrsa commented Mar 30, 2023 via email

@vadrsa vadrsa force-pushed the csharp-enum-member-attribute branch from ff542be to 4581336 Compare March 30, 2023 20:27
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution! Can you add an entry to the changelog please? ( Un released, changed)

…SerializationName is different from CodeEnumOption.Name
@vadrsa vadrsa force-pushed the csharp-enum-member-attribute branch from 4581336 to bf10976 Compare March 30, 2023 21:26
@vadrsa vadrsa requested a review from baywet March 30, 2023 21:26
@vadrsa
Copy link
Author

vadrsa commented Mar 30, 2023

Thanks a lot for the contribution! Can you add an entry to the changelog please? ( Un released, changed)

Done

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@baywet baywet enabled auto-merge March 30, 2023 22:04
@baywet baywet merged commit 9a09218 into microsoft:main Mar 30, 2023
@vadrsa vadrsa deleted the csharp-enum-member-attribute branch March 31, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants