Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP order the inheritance index #2452

Closed
wants to merge 1 commit into from

Conversation

andreaTP
Copy link
Contributor

Opening this as draft for visibility, it would be great if someone with a deeper C# and Inheritance index knowledge can take over this rough implementation (no need for attributions, an alternative PR is perfectly fine 🙂 ).

This seems to be fixing #2442 , but it's missing:

  • an atomic index increment (it's currently possible to end up with duplicated indexes when running the code in parallel)
  • possibly a "more principled" ordering scheme, e.g. based on depth
  • a proper explanation of the behavior

@andreaTP
Copy link
Contributor Author

These changes make the behavior reproducible but are not fixing the underlying bug 🙁

@andreaTP
Copy link
Contributor Author

Closing as we decided to move ahead on a different path.

@andreaTP andreaTP closed this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant