Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Raw URL support for Request Builders. #2225

Merged
merged 16 commits into from
Feb 2, 2023
Merged

PHP Raw URL support for Request Builders. #2225

merged 16 commits into from
Feb 2, 2023

Conversation

SilasKenneth
Copy link
Member

@SilasKenneth SilasKenneth commented Feb 1, 2023 •
edited
Loading

  • Add support for raw urls.
  • Change parameter description.

Generation diff:

@SilasKenneth SilasKenneth marked this pull request as ready for review February 1, 2023 12:03
baywet
baywet requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the work, a few comments

SilasKenneth and others added 12 commits February 2, 2023 11:20
@SilasKenneth
Add support for raw urls.
d74ee8e
@SilasKenneth
Change parameter description.
a07fb70
@SilasKenneth
Add changelog entry.
eb35f4b
@SilasKenneth @baywet
Update src/Kiota.Builder/Refiners/PhpRefiner.cs
59b57ac 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeEnumWriter.cs
73d4c6a 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeEnumWriter.cs
c2f8be5 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeMethodWriter.cs
d7f4516 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeMethodWriter.cs
1066590 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeMethodWriter.cs
d27973c 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeMethodWriter.cs
ba829a8 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeMethodWriter.cs
4b04b70 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth @baywet
Update src/Kiota.Builder/Writers/Php/CodeMethodWriter.cs
b26cf1a 
Co-authored-by: Vincent Biret <[email protected]>
@SilasKenneth SilasKenneth requested a review from baywet February 2, 2023 11:44
@SilasKenneth SilasKenneth linked an issue Feb 2, 2023 that may be closed by this pull request
PHP - adds support for setting the raw url of a request builder #2205
Closed
@SilasKenneth SilasKenneth self-assigned this Feb 2, 2023
baywet
baywet approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for implementing the changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.6% 92.6% Coverage
0.0% 0.0% Duplication

@SilasKenneth SilasKenneth merged commit cd48833 into main Feb 2, 2023
@SilasKenneth SilasKenneth deleted the feat/raw-url-support branch February 2, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

@rkodev rkodev Awaiting requested review from rkodev

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

Assignees

@SilasKenneth SilasKenneth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP - adds support for setting the raw url of a request builder
2 participants
@SilasKenneth @baywet