Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source generator for the version of this project #2149

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

andreaTP
Copy link
Contributor

Fixes #2147

I have attempted and failed to use the Microsoft.Build package (dependencies and other errors even using it in the tests...).

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

In addition to my comments, a entry in the changelog is missing.

@andreaTP
Copy link
Contributor Author

Changelog added, @baywet if you find a reference for a different approach to the problem I'm up to look at it 🙂 .
It was not "trivial" to get it working, but highly instructive on .NET toolchain etc.

@baywet baywet merged commit f14ca01 into microsoft:main Jan 12, 2023
@baywet
Copy link
Member

baywet commented Jan 13, 2023

@andreaTP I just realized that the dotnet request adapter also relies on assembly metadata. You might want to replicate the change you've made here over there and the github search functionality won't work in your scenario because of that.
https://github.com/microsoft/kiota-http-dotnet/blob/10863ce94fabfcab28fa679aa4a791c02f999458/src/Middleware/Options/UserAgentHandlerOption.cs#L28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KiotaLock fails instantiation on the browser-wasm runtime
2 participants