-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional compilation for Nullable ref types #2146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting the work here, great work so far. A couple of remarks to help you through the process:
Would additional data properties need any annotation?
Same thing for complex types properties (single value of other types being generated)?
Did you start the work on the kiota dependencies? I'm not sure what the impact would be on interfaces since their prototype would change?
I think the methods return types (when tasks of something) are still missing.
Thanks for checking this out @baywet,
I believe we are okay with these as they are initialized in the constructor with default non-null values meaning they won't be null.
I believe this is catered for example https://github.com/microsoft/kiota-samples/blob/4855fb63973b0ae20b602245bab902517694a686/msgraph-mail/dotnet/Models/Message.cs#L22
This is still WIP(Added as TODOs in the description to make clearer). I was first trying to get to understand what types would really need the annotations in the generated code as we already generate a bit of error handling code and initializers that assure some types won't be null and therefore would not need annotations. |
a5528c0
to
bbcdda2
Compare
Kudos, SonarCloud Quality Gate passed! |
Closes #2073