Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/hardcoded error module names #2004

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Nov 28, 2022

Remove hardcoded o_data_error module and sets it dynamic based on the error class name

fixes #1999

andrueastman
andrueastman previously approved these changes Nov 28, 2022
Base automatically changed from bugfix/python-indentation to main November 28, 2022 16:29
baywet
baywet previously approved these changes Nov 29, 2022
@baywet baywet dismissed stale reviews from andrueastman and themself via 293c3dd November 29, 2022 13:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@samwelkanda samwelkanda merged commit f4ed1b1 into main Nov 29, 2022
@samwelkanda samwelkanda deleted the bugfix/hardcoded-error-module-names branch November 29, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python type:bug A broken experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Kiota python generator code to set error_map uses undefined variable
3 participants