Remove Class Name Prefix from Nested Classes #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramsessanchez
requested review from
andrueastman,
baywet,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc,
calebkiage,
Ndiritu and
rkodev
as code owners
This was referenced Nov 17, 2022
Signed-off-by: Vincent Biret <[email protected]>
baywet
requested changes
Nov 17, 2022
Co-authored-by: Eastman <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
baywet
requested changes
Nov 18, 2022
…-TestChange Java/request info instantiation test change
Just one last thing before we forget and I think it should be good |
baywet
requested changes
Nov 22, 2022
Co-authored-by: Vincent Biret <[email protected]>
Co-authored-by: Vincent Biret <[email protected]>
This was referenced Nov 22, 2022
andrueastman
previously approved these changes
Nov 23, 2022
baywet
previously approved these changes
Nov 23, 2022
baywet
previously approved these changes
Nov 29, 2022
baywet
previously approved these changes
Nov 30, 2022
baywet
approved these changes
Nov 30, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the long nested-class name issue detailed in #1949
Removes instances of anonymous classes. This was done to address the issue of having too many classes at compile time, this was causing the daemons to suddenly disappear due to an overload of heap memory. Removing our uses of anonymous classes prevents this and reduces our file count size at compile time by over 50% for both v1 and beta libraries.