"Splits parsable interface for ruby + Duration, Time, and Date Support" #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rosoft/kiota into osose-refiners-ruby-features
baywet
requested changes
Aug 11, 2022
...ruby/json/microsoft_kiota_serialization/lib/microsoft_kiota_serialization/json_parse_node.rb
Outdated
Show resolved
Hide resolved
...n/microsoft_kiota_serialization/lib/microsoft_kiota_serialization/json_parse_node_factory.rb
Outdated
Show resolved
Hide resolved
...microsoft_kiota_serialization/lib/microsoft_kiota_serialization/json_serialization_writer.rb
Outdated
Show resolved
Hide resolved
...t_kiota_serialization/lib/microsoft_kiota_serialization/json_serialization_writer_factory.rb
Outdated
Show resolved
Hide resolved
6 tasks
baywet
reviewed
Aug 11, 2022
serialization/ruby/json/microsoft_kiota_serialization/spec/files/email_address.rb
Outdated
Show resolved
Hide resolved
osose-e
changed the title
osose-e
requested review from
andrueastman,
darrelmiller,
zengin,
MIchaelMainer,
ddyett,
peombwa,
nikithauc,
ramsessanchez,
calebkiage and
Ndiritu
as code owners
baywet
approved these changes
Aug 12, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1654
fixes #1644