Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a casing bug in generated Ruby code #1763

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Fixing a casing bug in generated Ruby code #1763

merged 5 commits into from
Jul 28, 2022

Conversation

osose-e
Copy link
Contributor

@osose-e osose-e commented Jul 26, 2022

fixes #1672

@osose-e osose-e marked this pull request as draft July 26, 2022 21:27
@osose-e osose-e marked this pull request as ready for review July 27, 2022 18:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Ndiritu Ndiritu mentioned this pull request Jul 28, 2022
Merged
Ndiritu
Ndiritu approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@Ndiritu Ndiritu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good - microsoft/kiota-samples#858

@osose-e osose-e merged commit 9373017 into main Jul 28, 2022
@osose-e osose-e deleted the osose-writers-ruby-features branch July 28, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zengin zengin zengin approved these changes

@Ndiritu Ndiritu Ndiritu approved these changes

@andrueastman andrueastman Awaiting requested review from andrueastman

@baywet baywet Awaiting requested review from baywet

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

@peombwa peombwa Awaiting requested review from peombwa

@nikithauc nikithauc Awaiting requested review from nikithauc

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@calebkiage calebkiage Awaiting requested review from calebkiage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

requestConfiguration is in camel case ruby
3 participants
@osose-e @zengin @Ndiritu