Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samwelkanda/codegen python #1200

Merged
merged 84 commits into from
Aug 18, 2022
Merged

Samwelkanda/codegen python #1200

merged 84 commits into from
Aug 18, 2022

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Feb 14, 2022

What this PR does?

This PR

  1. Closes Python generation support #163

Tasks:

  • Add python language in the options
  • Add the python path segmenter
  • Add the main python language writer
  • Add unit tests for the writers
  • Add an additional python refiner
  • Add unit test for the new refiner methods
  • [Add the sample generation for python]
  1. Fixes error handling in python request adapter  #1158 in generated code

  2. Fixes Python discriminator support #1256 in generated code

Tasks:

  • update deserializer method generation to pass the factory for the properties + update unit tests
  • update request executor generation to pass the factory to the request adapter send method + update unit tests
  • implement factory method generation + unit tests
  • use refiner AddDiscriminatorMappingsUsingsToParentClasses to add reference to types in discriminator mapping
  1. Fixes python - implement uint8 int8 and float128 support for serialization #1369

Tasks:

  • update the convention service with the additional mappings
  1. Fixes python - baseUrl set on request adapter is overwritten by generated client constructor #1468

Tasks:

  • Add conditional to check if base url has already been set
  1. Fixes python field deserializers simplification #1492 in generated code

Tasks:

  • Update code method writer to use current class for deserialization as opposed to passing a parameter
  1. Fixes python support for special characters in query parameters #1511 in generated code

  2. Fixes Request configuration revamp (Python) #1539 in generated code

@samwelkanda samwelkanda added this to the TypeWriter Replacement milestone Feb 14, 2022
@samwelkanda samwelkanda self-assigned this Feb 14, 2022
baywet
baywet previously requested changes Feb 14, 2022
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting the work here!

@baywet
Copy link
Member

baywet commented Mar 2, 2022

@samwelkanda FYI I just merged main into this branch to solve conflicts with all recent changes. I didn't rebase in case you have local uncomitted or unpushed changes to avoid making your life more complicated. Just remember to pull next time you work on this.

@sonarqubecloud

This comment was marked as outdated.

@baywet baywet linked an issue Apr 1, 2022 that may be closed by this pull request
12 tasks
@sonarqubecloud

This comment was marked as outdated.

@samwelkanda samwelkanda force-pushed the samwelkanda/codegen-python branch from 57ef36f to f6d8a37 Compare June 15, 2022 09:26
@sonarqubecloud

This comment was marked as outdated.

@samwelkanda samwelkanda force-pushed the samwelkanda/codegen-python branch from 08b53d4 to 101cea9 Compare July 19, 2022 15:20
@samwelkanda samwelkanda requested a review from baywet August 17, 2022 20:39
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Happy to approve once @baywet is finished reviewing.

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking the time to refarctor

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@samwelkanda samwelkanda requested a review from baywet August 18, 2022 12:45
@samwelkanda samwelkanda merged commit 5022d30 into main Aug 18, 2022
@samwelkanda samwelkanda deleted the samwelkanda/codegen-python branch August 18, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants