You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
baywet opened this issue
Sep 15, 2021
· 4 comments
· Fixed by #683
Assignees
Labels
CsharpPull requests that update .net codefixedgeneratorIssues or improvements relater to generation capabilities.GoJavaRubyTypeScriptPull requests that update Javascript code
Recent feedback in the following issues has proven limitations in the way URLs are built via the fluent API. Kiota generated request builders are currently storing the previously built URL in a current path property, and appending the current segment (with it's parameters) to it to pass it to the next request builder and/or execute the request.
Here is a high-level list of what needs to happen:
The current Path property needs to be renamed to Uri template and contain the full URI + an expansion of any query parameter
An additional dictionary/map of currentUriTemplateValues property needs to be added to request builders, and request builders constructors
Code writers for each language need to be updated to account for those changes, and pass the current values instead of the current path
Code indexers/navigation methods (path parameters) need to add the additional parameters to the map before passing it to the next request builder
The request information needs a setter method for the URI that takes in a template and the parameters and resolves to as URI
once changes are made in other languages check the progress on PHP Generation #664 and either rebase to implement changes in PHP or create a separate issue for it. AB#11152
The text was updated successfully, but these errors were encountered:
This is probably going to introduce a regression: using the request builders with raw URLs.
We should probably add an overload constructor that'd accept the raw URL, set it as the only url template parameter with a special key for the request information, which would in terms set the request information raw URL.
For typescript we can use a union type (map | string) and implement this behavior as well.
CsharpPull requests that update .net codefixedgeneratorIssues or improvements relater to generation capabilities.GoJavaRubyTypeScriptPull requests that update Javascript code
Recent feedback in the following issues has proven limitations in the way URLs are built via the fluent API. Kiota generated request builders are currently storing the previously built URL in a current path property, and appending the current segment (with it's parameters) to it to pass it to the next request builder and/or execute the request.
This shows shortcomings for:
We need to rework the generator, the language writers and the abstractions libraries to properly implement the query and path parameters and a proper way to do so would be to use URI templates.
Here is a high-level list of what needs to happen:
AB#11152
The text was updated successfully, but these errors were encountered: