Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using kiota client generate an empty output folder is generated #5559

Closed
maisarissi opened this issue Oct 8, 2024 · 2 comments
Closed
Labels
Milestone

Comments

@maisarissi
Copy link
Contributor

maisarissi commented Oct 8, 2024

After generating clients and plugin in the following structure:

/clients-plugins
 └─.kiota
    └─apimanifest.json
    └─workspace.json 
    └─documents
       └─GraphAdminCSharp
         └─openapi.yaml
       └─GraphChatsJava
         └─openapi.yaml
       └─RepairsPlugin
         └─openapi.yaml
 └─GraphAdminCSharp
    └─ # Generated code files
 └─GraphChatsJava
    └─ # Generated code files
 └─RepairsPlugin
    └─ # Generated plugin files

When I run in .../clients-plugins folder the following command:

kiota client generate

All my clients are updated based on the workspace.json file, however, an empty output folder is created even when I don't have this folder as output directory for any of my clients.

Expected

We should generate all clients based on the workspace.json file and their output directory. If there is no client using output folder as the output directory, no empty output folder should be created.

@maisarissi maisarissi added type:bug A broken experience status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Oct 8, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Oct 8, 2024
@baywet
Copy link
Member

baywet commented Oct 8, 2024

@maisarissi what version are you testing with? This recently got merged #5429

@andrueastman andrueastman added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Oct 9, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Waits for author 🔁 in Kiota Oct 9, 2024
@maisarissi
Copy link
Contributor Author

maisarissi commented Oct 9, 2024

I used Kiota CLI 1.19 and got the empty folder. Just saw that the issue will be part of the 1.19.1 patch. Thanks!

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 and removed status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels Oct 9, 2024
@github-project-automation github-project-automation bot moved this from Waits for author 🔁 to Done ✔️ in Kiota Oct 9, 2024
@baywet baywet added this to the Kiota v1.19.1 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants