Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go files names should not end with _windows.go #4407

Closed
baywet opened this issue Mar 26, 2024 · 1 comment · Fixed by #4540
Closed

go files names should not end with _windows.go #4407

baywet opened this issue Mar 26, 2024 · 1 comment · Fixed by #4540
Assignees
Labels
Go help wanted Issue caused by core project dependency modules or library type:bug A broken experience
Milestone

Comments

@baywet
Copy link
Member

baywet commented Mar 26, 2024

We've had to patch the beta weekly releases for the longest time example
Now those changes are trickling down to v1.
Both set of manual changes are making our weekly releases costlier than they need to (somebody need to check why the CI failed, cherry-pick the patch etc...)

It turns out that some suffixes are special cased for code variants on the platform and since our build agents are mostly linux, the files ending with _windows.go are being excluded.

We should update the go Path segmenter to escape anything ending with:

  • _windows.go
  • _test.go
  • _unix.go
  • _others.go
  • _amd64.go

(there may be more, finding some official documentation on the topic would be helpful)

@baywet baywet added type:bug A broken experience Go labels Mar 26, 2024
@baywet baywet added this to the Kiota v1.14 milestone Mar 26, 2024
@baywet baywet added this to Kiota Mar 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in Kiota Mar 26, 2024
@baywet baywet added the help wanted Issue caused by core project dependency modules or library label Mar 26, 2024
@rkodev rkodev self-assigned this Apr 22, 2024
@rkodev
Copy link
Contributor

rkodev commented Apr 22, 2024

The filename suffixes for operating system-specific files are based on the standard GOOS values. This is the complete list
https://github.com/golang/go/blob/master/src/go/build/syslist.go

@rkodev rkodev moved this from Todo 📃 to In Progress 🚧 in Kiota Apr 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✔️ in Kiota Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go help wanted Issue caused by core project dependency modules or library type:bug A broken experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants