Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing contentType by reference instead of by Value for Go StreamContent #3830

Closed
rkodev opened this issue Nov 29, 2023 · 0 comments · Fixed by #3834
Closed

Passing contentType by reference instead of by Value for Go StreamContent #3830

rkodev opened this issue Nov 29, 2023 · 0 comments · Fixed by #3834
Assignees
@rkodev
Labels
Go type:bug A broken experience WIP
Milestone
Kiota v1.9

Comments

@rkodev
Copy link
Contributor

rkodev commented Nov 29, 2023

The func requestInfo.SetStreamContentAndContentType in Go expects the content type string to be passed by value and not by reference https://github.com/microsoft/kiota-abstractions-go/blob/920cc73050b562c875f3c7a88ba93197e52dbe68/request_information.go#L232C36-L232C58

The var contentType should be cast to pass by val
@github-project-automation github-project-automation bot moved this to Todo in Kiota Nov 29, 2023
This was referenced Nov 29, 2023
Merged
Merged
rkodev added a commit to microsoftgraph/msgraph-sdk-go that referenced this issue Nov 29, 2023
@rkodev
Fix pass by ref related microsoft/kiota#3830
63c31fc
rkodev added a commit to microsoftgraph/msgraph-sdk-go that referenced this issue Nov 29, 2023
@andrueastman @rkodev
Generated models and request builders (#625)
a233e14 
* Update generated files with build 129710

* Update changelog

* Fix pass by ref related microsoft/kiota#3830

---------

Co-authored-by: Microsoft Graph DevX Tooling <[email protected]>
Co-authored-by: rkodev <[email protected]>
rkodev added a commit to microsoftgraph/msgraph-beta-sdk-go that referenced this issue Nov 29, 2023
@rkodev
Fix pass by ref related microsoft/kiota#3830
882a6fb
@rkodev rkodev self-assigned this Nov 29, 2023
rkodev added a commit to microsoftgraph/msgraph-beta-sdk-go that referenced this issue Nov 29, 2023
@rkodev
Fix pass by ref related microsoft/kiota#3830
9866b33
@rkodev rkodev added type:bug A broken experience Go labels Nov 29, 2023
@rkodev rkodev added this to the Kiota v1.9 milestone Nov 29, 2023
@rkodev rkodev mentioned this issue Nov 29, 2023
Merged
@rkodev rkodev moved this from Todo to In Progress in Kiota Nov 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkodev rkodev

Labels
Go type:bug A broken experience WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.9
Development

Successfully merging a pull request may close this issue.

Pass go request content by val not ref microsoft/kiota
1 participant
@rkodev