Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript enums and flag are misaligned for serialization method #3260

Closed
baywet opened this issue Sep 5, 2023 · 0 comments · Fixed by #3261
Closed

TypeScript enums and flag are misaligned for serialization method #3260

baywet opened this issue Sep 5, 2023 · 0 comments · Fixed by #3261
Assignees
@andrueastman
Labels
type:bug A broken experience TypeScript Pull requests that update Javascript code WIP
Milestone
Kiota v1.6

Comments

@baywet
Copy link
Member

baywet commented Sep 5, 2023

regression of #3240

I think some of the changes we recently made for enums had negative side effects on the typescript generation.

The type passed to serialization and the properties types seem misaligned. Can you have a look please?

Generated models and request builders · microsoftgraph/msgraph-sdk-typescript@23b4a1b (github.com)
@baywet baywet added type:bug A broken experience TypeScript Pull requests that update Javascript code labels Sep 5, 2023
@baywet baywet added this to the Kiota v1.6 milestone Sep 5, 2023
@baywet baywet added this to Kiota Sep 5, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Sep 5, 2023
@andrueastman andrueastman moved this from Todo to In Progress in Kiota Sep 6, 2023
@andrueastman andrueastman mentioned this issue Sep 6, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kiota Sep 6, 2023
@baywet baywet mentioned this issue Sep 8, 2023
Closed
This was referenced Sep 11, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 19, 2023
Merged
Merged
Merged
Merged
@dependabot dependabot bot mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrueastman andrueastman

Labels
type:bug A broken experience TypeScript Pull requests that update Javascript code WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.6
Development

Successfully merging a pull request may close this issue.

Fixes bitwise enum serialization in typescript. microsoft/kiota
2 participants
@andrueastman @baywet