-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot support APIs that have path parameters that use reserved characters that must not be percent encoded. #2320
Comments
The |
After testing with Microsoft Graph we identified that the one place we know of that uses reserved characters in a path parameter, the gateway successfully handles this scenario.
Therefore we can move this issue to 1.2. |
@darrelmiller, since we don't have "customer demand" for this, and since this is blocked by dependencies, are you ok with moving it to 1.4 for now? |
If I understand this issue correctly we'd need to:
|
We don't need this for Graph so we don't need step 2, 3 or 5. Just 1 + 4. I'm fine if we push this to a late milestone due to lack of customer requests. |
Thanks for the precision. It's a small change then I'll go ahead and document the extension and follow up with implementation. Let's leave it in 1.6 for now. |
Currently OpenAPI does not allow Path parameters to use the
allowReserved
property. This is a problem for APIs that want to use these characters in their APIs. The NightScout v2 API is an example where it uses a comma separated list of values in a path segment.However, UriTemplates do allow this. https://www.rfc-editor.org/rfc/rfc6570#section-3.2.3
We need to invent a
x-AllowReserved
as a workaround. OpenAPI didn't allow it because it would make it possible for a parameter to introduce new path segments. That would make operation resolution non-deterministic.The text was updated successfully, but these errors were encountered: