Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript - Add ResponseStatusCode to API error/exception #2241

Closed
3 tasks done
baywet opened this issue Feb 2, 2023 · 0 comments · Fixed by microsoft/kiota-typescript#617
Closed
3 tasks done

TypeScript - Add ResponseStatusCode to API error/exception #2241

baywet opened this issue Feb 2, 2023 · 0 comments · Fixed by microsoft/kiota-typescript#617
Assignees
@koros
Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code
Milestone
Kiota v1.2

Comments

@baywet
Copy link
Member

baywet commented Feb 2, 2023 •
edited by andrueastman
Loading

related to #2216
To improve the error handling experience we need to add the status code the the main api error type:

  • add a ResponseStatusCode field to the api exception class
  • add corresponding accessors (if needed)
  • populate the information in the request adapter when an error is encountered

Examples
microsoft/kiota-dotnet#68
microsoft/kiota-http-dotnet#82
@baywet baywet added TypeScript Pull requests that update Javascript code enhancement New feature or request labels Feb 2, 2023
@baywet baywet added this to the Kiota post-GA milestone Feb 2, 2023
@baywet baywet self-assigned this Feb 2, 2023
@baywet baywet assigned koros and unassigned baywet Apr 5, 2023
@baywet baywet modified the milestones: Backlog, Kiota v1.3 Apr 5, 2023
@github-project-automation github-project-automation bot moved this to Todo in Kiota Apr 25, 2023
@andrueastman andrueastman mentioned this issue Apr 26, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Kiota Apr 26, 2023
@baywet baywet modified the milestones: Kiota v1.3, Kiota v1.2 Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koros koros

Labels
enhancement New feature or request TypeScript Pull requests that update Javascript code
Projects
Kiota
Archived in project
Milestone
Kiota v1.2
Development

Successfully merging a pull request may close this issue.

Adds response headers to API error microsoft/kiota-typescript
2 participants
@koros @baywet