Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP - adds support for setting the raw url of a request builder #2205

Closed
baywet opened this issue Jan 30, 2023 · 0 comments · Fixed by #2225
Closed

PHP - adds support for setting the raw url of a request builder #2205

baywet opened this issue Jan 30, 2023 · 0 comments · Fixed by #2225
Assignees
Milestone

Comments

@baywet
Copy link
Member

baywet commented Jan 30, 2023

related #628
to avoid people having to drop the whole generated experience when they already have a URL (delta) or need to build one themselves (expansion limitations for drives), request builders should have a constructor that accepts a request adapter and a raw url (string)
This constructor can either be an overload or a union type for the path parameters if that makes sense.
If a string is provided, set it to
aw-request-url in the path paramters. (generation)
In the abstractions update the URI getter to parse and return that url if provided on this key see the dotnet implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants