Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requestConfiguration is in camel case ruby #1672

Closed
osose-e opened this issue Jun 27, 2022 · 1 comment · Fixed by #1763
Closed

requestConfiguration is in camel case ruby #1672

osose-e opened this issue Jun 27, 2022 · 1 comment · Fixed by #1763
Assignees
@osose-e
Labels
fixed Ruby type:bug A broken experience

Comments

@osose-e
Copy link
Contributor

osose-e commented Jun 27, 2022

https://github.com/microsoft/kiota-samples/blob/092356cbaeb09fc2e3632ce2fee3db116b4c9fbc/msgraph-mail/ruby/graphrubyv4/users/item/messages/messages_request_builder.rb#L60

Should requestConfiguration be snake case instead of camel case? It looks like the parameters a couple lines above are snake case, but comments are camel case, so I am not sure.
@osose-e osose-e added the type:bug A broken experience label Jun 27, 2022
@baywet baywet assigned osose-e and unassigned baywet Jun 28, 2022
@baywet baywet transferred this issue from microsoft/kiota-samples Jun 28, 2022
@baywet baywet changed the title requestConfiguration is in camel case requestConfiguration is in camel case ruby Jun 28, 2022
@baywet baywet added the Ruby label Jun 28, 2022
@baywet
Copy link
Member

baywet commented Jun 28, 2022

very good catch! yes it should, added to the backlog.

@osose-e osose-e mentioned this issue Jul 26, 2022
Merged
@ghost ghost added the WIP label Jul 26, 2022
@ghost ghost added fixed and removed WIP labels Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@osose-e osose-e

Labels
fixed Ruby type:bug A broken experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing a casing bug in generated Ruby code microsoft/kiota
2 participants
@baywet @osose-e