Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsable interface needs to be splat in ruby #1654

Closed
1 of 3 tasks
Tracked by #1049
baywet opened this issue Jun 23, 2022 · 1 comment · Fixed by #1765
Closed
1 of 3 tasks
Tracked by #1049

parsable interface needs to be splat in ruby #1654

baywet opened this issue Jun 23, 2022 · 1 comment · Fixed by #1765
Assignees
Labels
fixed Ruby type:bug A broken experience

Comments

@baywet
Copy link
Member

baywet commented Jun 23, 2022

follow up of #737 and associated pull request for ruby

TODO:

  • move the additional data property from Parsable interface to a new additional property holder interface in abstractions
  • update the ruby refiner to replace that type reference when needed
  • update the serialization JSON implementation (parse node) to leverage AdditionalDataHolder instead of parsable (in cast of casts) (not needed in ruby)
@baywet baywet added type:bug A broken experience Ruby labels Jun 23, 2022
@baywet
Copy link
Member Author

baywet commented Jul 15, 2022

Example for refiner changes

private static void CorrectImplements(ProprietableBlockDeclaration block) {

new (x => x is CodeClass @class && @class.IsOfKind(CodeClassKind.Model) && @class.Properties.Any(x => x.IsOfKind(CodePropertyKind.AdditionalData)),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Ruby type:bug A broken experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants