Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiota generator logging and observability #1486

Closed
baywet opened this issue Apr 1, 2022 · 3 comments
Closed

Kiota generator logging and observability #1486

baywet opened this issue Apr 1, 2022 · 3 comments
Assignees
Labels
blocked This work can't be done until an external dependent work is done. enhancement New feature or request generator Issues or improvements relater to generation capabilities. needs more information
Milestone

Comments

@baywet
Copy link
Member

baywet commented Apr 1, 2022

We need to align with hidi and provide a good observability experience.

Questions that still need to be answered:

  • Are kiota/hidi going to be hosted as a service? (ILogger vs System.Diagnostics)
  • What are the parameters for logging levels? (ll or v?)
  • What are the logging levels? (review whether ILogger is aligned with Open Telemetry)
  • Where do we need scopes/activities?
  • Do we still need the stop watches?
@baywet baywet added the generator Issues or improvements relater to generation capabilities. label Apr 1, 2022
@baywet baywet added this to Kiota Apr 1, 2022
@baywet baywet moved this to Todo in Kiota Apr 1, 2022
@baywet baywet added the enhancement New feature or request label Apr 1, 2022
@baywet baywet added the blocked This work can't be done until an external dependent work is done. label May 16, 2022
@nikithauc

This comment was marked as off-topic.

@baywet

This comment was marked as off-topic.

@baywet
Copy link
Member Author

baywet commented Jan 20, 2023

Meeting notes:
Instrumenting the code to have spans for the code under the hood of Kiota would not be super helpful due to the complexity of the code and how nested the spans are going to be.
If somebody hosts Kiota as a service, they can configure the logger they pass to output to OpenTelemetry or system.diagnostics and get an overview of the whole generation process as a single span.
No actions to take on our side. Closing.

@baywet baywet closed this as completed Jan 20, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Kiota Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This work can't be done until an external dependent work is done. enhancement New feature or request generator Issues or improvements relater to generation capabilities. needs more information
Projects
Archived in project
Development

No branches or pull requests

3 participants