Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/response handler #734

Merged
merged 6 commits into from
Jul 4, 2023
Merged

feature/response handler #734

merged 6 commits into from
Jul 4, 2023

Conversation

baywet
Copy link
Member

@baywet baywet commented Jul 3, 2023

Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet temporarily deployed to build_test July 3, 2023 19:23 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test July 3, 2023 19:24 — with GitHub Actions Inactive
@baywet baywet temporarily deployed to build_test July 3, 2023 19:24 — with GitHub Actions Inactive
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Most of the diff is the generated code in the test project.

@baywet baywet temporarily deployed to build_test July 4, 2023 06:33 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Generated "test-kiota-typescript-libraries" SDK package:

File count Size (Kb) Unpacked (Kb)
190651 15667.41 188500.01

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Generated sample app bundle:

Stat Size (Kb) Parsed Size (Kb) Gzipped (Kb)
35919.52 9517.80 534.78

@baywet baywet merged commit 798a589 into main Jul 4, 2023
@baywet baywet deleted the feature/response-handler branch July 4, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants