From 8bbcde33d5a2fef9cb6f6aca7358ad8877a68ff3 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Mon, 12 Aug 2024 13:10:01 -0400 Subject: [PATCH 1/2] fix: set value is makred as obsolete --- json_parse_node.go | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/json_parse_node.go b/json_parse_node.go index 18396de..fcf5289 100644 --- a/json_parse_node.go +++ b/json_parse_node.go @@ -88,11 +88,11 @@ func loadJsonTree(decoder *json.Decoder) (*JsonParseNode, error) { i, err := number.Int64() c := &JsonParseNode{} if err == nil { - c.SetValue(&i) + c.setValue(&i) } else { f, err := number.Float64() if err == nil { - c.SetValue(&f) + c.setValue(&f) } else { return nil, err } @@ -101,42 +101,42 @@ func loadJsonTree(decoder *json.Decoder) (*JsonParseNode, error) { case string: v := token.(string) c := &JsonParseNode{} - c.SetValue(&v) + c.setValue(&v) return c, nil case bool: c := &JsonParseNode{} v := token.(bool) - c.SetValue(&v) + c.setValue(&v) return c, nil case int8: c := &JsonParseNode{} v := token.(int8) - c.SetValue(&v) + c.setValue(&v) return c, nil case byte: c := &JsonParseNode{} v := token.(byte) - c.SetValue(&v) + c.setValue(&v) return c, nil case float64: c := &JsonParseNode{} v := token.(float64) - c.SetValue(&v) + c.setValue(&v) return c, nil case float32: c := &JsonParseNode{} v := token.(float32) - c.SetValue(&v) + c.setValue(&v) return c, nil case int32: c := &JsonParseNode{} v := token.(int32) - c.SetValue(&v) + c.setValue(&v) return c, nil case int64: c := &JsonParseNode{} v := token.(int64) - c.SetValue(&v) + c.setValue(&v) return c, nil case nil: return nil, nil @@ -146,8 +146,13 @@ func loadJsonTree(decoder *json.Decoder) (*JsonParseNode, error) { return nil, nil } -// SetValue sets the value represented by the node -func (n *JsonParseNode) SetValue(value interface{}) { +// setValue is obsolete, parse nodes are not meant to be settable externally +func (n *JsonParseNode) SearchetValue(value interface{}) { + n.setValue(value) +} + +// setValue sets the value represented by the node +func (n *JsonParseNode) setValue(value interface{}) { n.value = value } From 8b97c2bcff0222d31e091c8d2c3a7aae33caf8a3 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Mon, 12 Aug 2024 13:12:23 -0400 Subject: [PATCH 2/2] fix: copilot getting in the way Signed-off-by: Vincent Biret --- json_parse_node.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/json_parse_node.go b/json_parse_node.go index fcf5289..2d94796 100644 --- a/json_parse_node.go +++ b/json_parse_node.go @@ -146,8 +146,8 @@ func loadJsonTree(decoder *json.Decoder) (*JsonParseNode, error) { return nil, nil } -// setValue is obsolete, parse nodes are not meant to be settable externally -func (n *JsonParseNode) SearchetValue(value interface{}) { +// SetValue is obsolete, parse nodes are not meant to be settable externally +func (n *JsonParseNode) SetValue(value interface{}) { n.setValue(value) }