Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Add support for enum member attribute #77

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

vadrsa
Copy link
Contributor

@vadrsa vadrsa commented Mar 30, 2023

Part of the fix for microsoft/kiota #2488

@vadrsa vadrsa force-pushed the support-enum-member-attribute branch from 624f644 to 124139b Compare March 30, 2023 21:38
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. A couple of comments.

@vadrsa vadrsa force-pushed the support-enum-member-attribute branch from 124139b to 26ac563 Compare March 31, 2023 17:18
@vadrsa vadrsa requested a review from baywet March 31, 2023 17:18
baywet
baywet previously approved these changes Mar 31, 2023
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes. @andrueastman for an additional review and release.

andrueastman
andrueastman previously approved these changes Apr 3, 2023
@andrueastman
Copy link
Member

Thanks for this @vadrsa

@andrueastman andrueastman dismissed stale reviews from baywet and themself via ebece78 April 3, 2023 06:05
@andrueastman andrueastman enabled auto-merge April 3, 2023 06:06
@andrueastman andrueastman merged commit 0af31e6 into microsoft:main Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants