Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/backing store support #101

Merged
merged 18 commits into from
Aug 4, 2023
Merged

Chore/backing store support #101

merged 18 commits into from
Aug 4, 2023

Conversation

samwelkanda
Copy link
Contributor

@samwelkanda samwelkanda commented Jul 19, 2023 •
edited
Loading

Enables backing store for Python.

Part of microsoft/kiota#2858

  • Add a backing store interface in the abstractions
  • Add a backed model interface in the abstractions
  • Add an in memory backing store implementation in the abstractions
  • Add a backing store factory interface in the abstractions
  • Implement the factory for the in memory backing store
  • Add a singleton for the backing store factory in the abstractions
  • Implement factories for proxy
  • [implement those factories for the backing store

Ndiritu
Ndiritu requested changes Jul 20, 2023
View reviewed changes
@samwelkanda samwelkanda marked this pull request as ready for review July 24, 2023 21:02
@samwelkanda samwelkanda requested a review from Ndiritu July 24, 2023 21:02
@samwelkanda samwelkanda mentioned this pull request Jul 24, 2023
Merged
3 tasks
baywet
baywet previously approved these changes Jul 25, 2023
View reviewed changes
Ndiritu
Ndiritu previously approved these changes Jul 25, 2023
View reviewed changes
@github-actions
Copy link
Contributor

This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged.

@samwelkanda samwelkanda dismissed stale reviews from andrueastman, Ndiritu, and baywet via 33c026d July 27, 2023 11:44
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will take a look shortly.

baywet
baywet previously approved these changes Jul 27, 2023
View reviewed changes
@samwelkanda samwelkanda requested a review from andrueastman July 27, 2023 12:09
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Jul 27, 2023
Merged
Merged
@samwelkanda samwelkanda merged commit 554697a into main Aug 4, 2023
@samwelkanda samwelkanda deleted the chore/backing-store-support branch August 4, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilasKenneth SilasKenneth SilasKenneth approved these changes

@baywet baywet baywet left review comments

@Ndiritu Ndiritu Ndiritu left review comments

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@ddyett ddyett Awaiting requested review from ddyett

@andrueastman andrueastman Awaiting requested review from andrueastman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samwelkanda @andrueastman @baywet @Ndiritu @SilasKenneth