Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

Adds support for nullable reference types #72

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Adds support for nullable reference types #72

merged 5 commits into from
Jan 17, 2023

Conversation

andrueastman
Copy link
Member

This PR is part of microsoft/kiota#2073

Changes include: -

  • Adds nullable markers to APIs that can return null.
  • Adds nullable feature in project as well as net6.0 target to allow for proper feature functionality. Also sets TreatWarningsAsErrors to alleviate any potential mistakes being ignored.

baywet
baywet reviewed Jan 13, 2023
View reviewed changes
@andrueastman andrueastman requested a review from baywet January 16, 2023 06:58
@andrueastman andrueastman mentioned this pull request Jan 16, 2023
Merged
@andrueastman andrueastman requested a review from baywet January 17, 2023 06:55
@andrueastman andrueastman marked this pull request as ready for review January 17, 2023 14:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.5% 84.5% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman merged commit 13653f8 into main Jan 17, 2023
@andrueastman andrueastman deleted the andrueastman/NRT branch January 17, 2023 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@baywet baywet baywet approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet