Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for nullable ref types #63

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Adds support for nullable ref types #63

merged 3 commits into from
Jan 17, 2023

Conversation

andrueastman
Copy link
Member

This PR is part of microsoft/kiota#2073

Changes include: -

  • Adds nullable markers to APIs that can return null.
  • Adds nullable feature in project as well as net6.0 target to allow for proper feature functionality. Also sets TreatWarningsAsErrors to alleviate any potential mistakes being ignored.

@andrueastman andrueastman self-assigned this Jan 13, 2023
baywet
baywet reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work. one thing I'm not clear on is what happens to all that nullability information when we target standard 2.0? shouldn't we have conditional directive here as well?

@andrueastman andrueastman marked this pull request as ready for review January 16, 2023 06:58
@andrueastman andrueastman requested a review from baywet January 16, 2023 06:58
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.2% 81.2% Coverage
0.0% 0.0% Duplication

@andrueastman andrueastman merged commit ac62342 into main Jan 17, 2023
@andrueastman andrueastman deleted the andrueastman/NRT branch January 17, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

Assignees

@andrueastman andrueastman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrueastman @baywet