Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add response status code to API exception #34

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Add response status code to API exception #34

merged 1 commit into from
Feb 10, 2023

Conversation

Ndiritu
Copy link
Contributor

@Ndiritu Ndiritu commented Feb 10, 2023

@Ndiritu Ndiritu self-assigned this Feb 10, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

SilasKenneth
SilasKenneth approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@SilasKenneth SilasKenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We will need to add getResponseStatusCode to ApiExceptionReserved words Set.

@Ndiritu Ndiritu merged commit 59dd728 into dev Feb 10, 2023
@Ndiritu Ndiritu deleted the fix/api-exception branch February 10, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilasKenneth SilasKenneth SilasKenneth approved these changes

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

@shemogumbe shemogumbe Awaiting requested review from shemogumbe

Assignees

@Ndiritu Ndiritu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ndiritu @SilasKenneth