Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundation: Evolution of styled helper #8823

Closed
JasonGore opened this issue Apr 23, 2019 · 2 comments
Closed

Foundation: Evolution of styled helper #8823

JasonGore opened this issue Apr 23, 2019 · 2 comments
Assignees

Comments

@JasonGore
Copy link
Member

JasonGore commented Apr 23, 2019

Consider the following:

Fabric 7

Action Status Note
Add API change policy to foundation. #8846
Export styled as legacyStyled from foundation. #8846
Remove createComponent export from OUFR. #8846
Move styled to new legacy-styled package. (Probably should remove legacyStyled from experiments.)
Stop exporting styled from utilities and OUFR.
Make codemod to change people from OUFR/utilities to legacy-styled
Codemod to support name change and importing from new location.
Change createComponent API to easily allow quick component prototyping and customization, like createComponent(view, { options }); #9072
Deprecate styled? Would also deprecate legacyStyled, causes build errors in charting and other packages using styled.

createComponent parity with styled

Action Status Note
defaultProps, getProps and fields support as applicable.
loadTheme observable support (#7088)
Perf and functionality improvements (#8797, #8843)

Improvements

  • Simple Scenarios
    • Is there any way use of withSlots can be removed or made optional?
    • Is there a way not to require use of getSlots for simple component scenarios?
      • In this case, how would style sections be created automatically? Require users to use getClassNames in this case similar to styled?

Fabric 8

Action Status Note
Remove styled (or at least move to foundation.) Remove styled export from OUFR.
Rename createComponent to styled
@khmakoto
Copy link
Member

khmakoto commented Feb 3, 2020

@JasonGore should we close this as well?

@JasonGore
Copy link
Member Author

Closing due to newer efforts that'll take an alternative approach to styled.

@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants