Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated lifecycle methods #8743

Closed
6 of 59 tasks
jdhuntington opened this issue Apr 17, 2019 · 2 comments
Closed
6 of 59 tasks

Fix deprecated lifecycle methods #8743

jdhuntington opened this issue Apr 17, 2019 · 2 comments
Assignees

Comments

@jdhuntington
Copy link
Contributor

jdhuntington commented Apr 17, 2019

  • apps/fabric-website/src/components/App/App.tsx
  • date-time/src/components/Calendar/Calendar.base.tsx
  • date-time/src/components/Calendar/CalendarDay/CalendarDay.base.tsx
  • experiments/src/components/Chiclet/Chiclet.base.tsx
  • experiments/src/components/Shimmer/Shimmer.base.tsx
  • experiments/src/components/Tile/Tile.tsx
  • experiments/src/components/TilesList/TilesList.tsx
  • experiments/src/components/VirtualizedList/VirtualizedList.tsx
  • experiments/src/utilities/BaseComponentMin.ts
  • experiments/src/utilities/BaseState.tsx
  • legacy/src/components/Nav/Nav.base.tsx (wontfix)
  • office-ui-fabric-react/src/components/Autofill/Autofill.tsx
  • office-ui-fabric-react/src/components/Autofill/Autofill.types.ts
  • office-ui-fabric-react/src/components/Breadcrumb/Breadcrumb.base.tsx
  • office-ui-fabric-react/src/components/Calendar/Calendar.tsx
  • office-ui-fabric-react/src/components/Calendar/CalendarDay.tsx
  • office-ui-fabric-react/src/components/Callout/CalloutContent.base.tsx
  • office-ui-fabric-react/src/components/Checkbox/Checkbox.base.tsx
  • office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx
  • office-ui-fabric-react/src/components/Coachmark/Coachmark.base.tsx
  • office-ui-fabric-react/src/components/Coachmark/PositioningContainer/PositioningContainer.tsx
  • office-ui-fabric-react/src/components/ColorPicker/ColorPicker.base.tsx
  • office-ui-fabric-react/src/components/ColorPicker/ColorRectangle/ColorRectangle.base.tsx
  • office-ui-fabric-react/src/components/ColorPicker/ColorSlider/ColorSlider.base.tsx
  • office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx
  • office-ui-fabric-react/src/components/ContextualMenu/ContextualMenu.base.tsx
  • office-ui-fabric-react/src/components/DatePicker/DatePicker.base.tsx
  • office-ui-fabric-react/src/components/DetailsList/DetailsList.base.tsx
  • office-ui-fabric-react/src/components/DetailsList/DetailsList.test.tsx
  • office-ui-fabric-react/src/components/DetailsList/DetailsRow.base.tsx
  • office-ui-fabric-react/src/components/DocumentCard/DocumentCardTitle.base.tsx
  • office-ui-fabric-react/src/components/Dropdown/Dropdown.base.tsx
  • office-ui-fabric-react/src/components/ExtendedPicker/BaseExtendedPicker.tsx
  • office-ui-fabric-react/src/components/FloatingPicker/BaseFloatingPicker.tsx
  • office-ui-fabric-react/src/components/FloatingPicker/Suggestions/SuggestionsControl.tsx
  • office-ui-fabric-react/src/components/FocusTrapZone/FocusTrapZone.tsx
  • office-ui-fabric-react/src/components/GroupedList/GroupHeader.base.tsx
  • office-ui-fabric-react/src/components/GroupedList/GroupedList.base.tsx
  • office-ui-fabric-react/src/components/Image/Image.base.tsx
  • office-ui-fabric-react/src/components/Layer/Layer.base.tsx
  • office-ui-fabric-react/src/components/List/List.tsx
  • office-ui-fabric-react/src/components/List/ListPage.tsx
  • office-ui-fabric-react/src/components/Modal/Modal.base.tsx
  • office-ui-fabric-react/src/components/OverflowSet/OverflowSet.base.tsx
  • office-ui-fabric-react/src/components/Persona/PersonaCoin/PersonaCoin.base.tsx
  • office-ui-fabric-react/src/components/Popup/Popup.tsx
  • office-ui-fabric-react/src/components/Rating/Rating.base.tsx
  • office-ui-fabric-react/src/components/ResizeGroup/ResizeGroup.base.tsx
  • office-ui-fabric-react/src/components/SearchBox/SearchBox.base.tsx
  • office-ui-fabric-react/src/components/SelectedItemsList/BaseSelectedItemsList.tsx
  • office-ui-fabric-react/src/components/Shimmer/Shimmer.base.tsx
  • office-ui-fabric-react/src/components/Shimmer/Shimmer.test.tsx
  • office-ui-fabric-react/src/components/SpinButton/SpinButton.tsx
  • office-ui-fabric-react/src/components/SwatchColorPicker/SwatchColorPicker.base.tsx
  • office-ui-fabric-react/src/components/TextField/MaskedTextField/MaskedTextField.tsx
  • office-ui-fabric-react/src/components/TextField/TextField.base.tsx
  • office-ui-fabric-react/src/components/Toggle/Toggle.base.tsx
  • office-ui-fabric-react/src/components/pickers/BasePicker.tsx
  • utilities/src/hoist.ts
@KevinTCoughlin
Copy link
Member

KevinTCoughlin commented Apr 18, 2019

FYI @jdhuntington I don't think the following line item is applicable, but rather a reference in an in-line comment:

office-ui-fabric-react/src/components/DetailsList/DetailsList.test.tsx

https://github.com/OfficeDev/office-ui-fabric-react/blob/ef7ccb8a9f91fe0829a7cf7e1fb7a2e4c58f62b0/packages/office-ui-fabric-react/src/components/DetailsList/DetailsList.test.tsx#L407

Also ListPage looks like an outdated prototype (TIL.) that is not exported which we can remove:

office-ui-fabric-react/src/components/List/ListPage.tsx

https://github.com/OfficeDev/office-ui-fabric-react/blob/ef7ccb8a9f91fe0829a7cf7e1fb7a2e4c58f62b0/packages/office-ui-fabric-react/src/components/List/ListPage.tsx#L16

@JasonGore
Copy link
Member

Replaced by #4613.

@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants