Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to TypeScript 3.3.3 #8040

Closed
jdhuntington opened this issue Feb 19, 2019 · 3 comments
Closed

Upgrade to TypeScript 3.3.3 #8040

jdhuntington opened this issue Feb 19, 2019 · 3 comments
Assignees
@jdhuntington
Labels
Area: Typescript

Comments

@jdhuntington
Copy link
Contributor

Upgrade all packages to depend on TypeScript 3.3.3.
@jdhuntington jdhuntington self-assigned this Feb 19, 2019
@micahgodbolt micahgodbolt mentioned this issue Feb 19, 2019
Closed
10 tasks
@aneeshack4 aneeshack4 removed their assignment Feb 20, 2019
@khmakoto
Copy link
Member

Bug #7874 should be fixed by the work done for this. In general, it seems that we will have to update all the components that can have children but don't have the specific children prop in their type definition.

@jdhuntington
Copy link
Contributor Author

Update: 4fca804 (presently part of the fabric-7 branch) builds everything up to and including OUFR with TypeScript 3.3.3. There are several temporary workarounds in place that are being tracked with the comment FABRIC7VALIDATE and FABRIC7TODO, but it is possible for someone to build. Also targets React 16.8.3 (cc #8041 )

@jdhuntington
Copy link
Contributor Author

Also tracking microsoft/TypeScript#30050 , which is currently being triggered by a set of things in BaseComponent, FocusZone, and FocusZone.types

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jdhuntington jdhuntington

Labels
Area: Typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdhuntington @aneeshack4 @khmakoto @msft-github-bot