Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate base theme into own package #8039

Closed
jdhuntington opened this issue Feb 19, 2019 · 0 comments
Closed

Separate base theme into own package #8039

jdhuntington opened this issue Feb 19, 2019 · 0 comments
Assignees

Comments

@jdhuntington
Copy link
Contributor

In Fabric 6, all consumers automatically import the default theme out-of-the-box. This is great for casual use but becomes an encumbrance once optimized size becomes a project goal.

Furthermore, most custom themes presently depend on the base theme that ships with Fabric. This has potential unfortunate side effects of changing the appearance of custom themes if design alterations are made in the base theme.

This feature covers separating the base theme into another package. It will be included in the default Fabric package, but it can be omitted by requiring an "unthemed" oufr-package instead. In conjunction, a separate theme base allows custom themes to depend on a specific version that will not be affected when upgrading the Fabric core.

@micahgodbolt micahgodbolt mentioned this issue Feb 19, 2019
10 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants