-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rating: Fluent theme #6745
Comments
@betrue-final-final |
Nice work. @Vitalius1, can you take the layout improvements and open a PR on current Fabric? |
@betrue-final-final Can you confirm the following changes and I will make them? thanks! Fluent Updates NeededUpdate star icon rest state color
Update on hover outline to fill (see screenshot below)
Add label for Rating component (see screenshot below)
|
@Vitalius1 thanks for referencing those PRs, it helped a lot with context! It seems like the accessibility issue came from the previous design with grey unchecked state. Since this change is just a matter of changing the hover state from a border outline to a fill, it might be safe to assume that the color used has been checked and passes accessibility, I'll confirm/deny with Ben! |
Update star icon rest state color: #605e5c Update on hover outline to fill (see screenshot below) Will remove label for Ratings in toolkit. |
No description provided.
The text was updated successfully, but these errors were encountered: