-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neutralSecondaryAlt color removal final one! #6575
Comments
@Vitalius1 any progress on this? |
It can be removed from the SASS variables (those weren't being exported until after the deprecation anyways), leave it in code where it is now for backwards compatibility. |
@phkuo I am a little bit confused on what do you mean by
Do you mean that anything in a |
I mean that it should be removed anywhere it is being consumed in Fabric components, but remain in place in the theming infrastructure code. i.e. deprecated but still technically supported |
#8098 is bringing back from deprecation |
Bug Report
This is to track the removal of the remaining of usage of
neutralSecondaryAlt
color across the repo as continuation of #5194 and #6500.I consider that this last issue should be the final cleanup and should be proceeded to only when we have answered the questions bellow.
Priorities and help requested:
Are you willing to submit a PR to fix? Yes
Requested priority: Normal
Describe the issue:
Here is where it can still be seen:
fabric-website
- should be as simple as confirming with designers on a replacementexample-app-base
- same as aboveexperiments
- most likely can be removed without breaking changes (it's experimental 😄 )styling
- @phkuo can this be removed? I assume not as it will break downstream but can you confirm?office-ui-fabric-react
- in here and here not sure if it needs to be left in this places. @phkuo do you have any context in here too?The text was updated successfully, but these errors were encountered: