Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neutralSecondaryAlt color removal final one! #6575

Closed
Vitalius1 opened this issue Oct 4, 2018 · 5 comments
Closed

neutralSecondaryAlt color removal final one! #6575

Vitalius1 opened this issue Oct 4, 2018 · 5 comments

Comments

@Vitalius1
Copy link
Contributor

Bug Report

This is to track the removal of the remaining of usage of neutralSecondaryAlt color across the repo as continuation of #5194 and #6500.
I consider that this last issue should be the final cleanup and should be proceeded to only when we have answered the questions bellow.

Priorities and help requested:

Are you willing to submit a PR to fix? Yes

Requested priority: Normal

Describe the issue:

Here is where it can still be seen:

  • fabric-website - should be as simple as confirming with designers on a replacement
  • example-app-base - same as above
  • experiments - most likely can be removed without breaking changes (it's experimental 😄 )
  • styling - @phkuo can this be removed? I assume not as it will break downstream but can you confirm?
  • office-ui-fabric-react - in here and here not sure if it needs to be left in this places. @phkuo do you have any context in here too?
@micahgodbolt
Copy link
Member

@Vitalius1 any progress on this?

@phkuo
Copy link
Contributor

phkuo commented Jan 3, 2019

It can be removed from the SASS variables (those weren't being exported until after the deprecation anyways), leave it in code where it is now for backwards compatibility.

@Vitalius1
Copy link
Contributor Author

@phkuo I am a little bit confused on what do you mean by

...leave it in code where it is now...

Do you mean that anything in a .scss file can be removed and in cases of it being used in a .ts file should be left as is?

@Vitalius1 Vitalius1 self-assigned this Jan 4, 2019
@phkuo
Copy link
Contributor

phkuo commented Jan 22, 2019

I mean that it should be removed anywhere it is being consumed in Fabric components, but remain in place in the theming infrastructure code. i.e. deprecated but still technically supported

@Vitalius1
Copy link
Contributor Author

#8098 is bringing back from deprecation neutralSecondaryAlt palette slot so this issue is no longer valid. Closing!

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants