Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persona Button: Support personas being rendered as buttons or links #1462

Closed
micahgodbolt opened this issue Apr 11, 2017 · 5 comments
Closed

Persona Button: Support personas being rendered as buttons or links #1462

micahgodbolt opened this issue Apr 11, 2017 · 5 comments
Labels
Component: Persona Needs: Backlog review Status: Blocked Resolution blocked by another issue Type: Feature
Milestone
Freezer

Comments

@micahgodbolt
Copy link
Member

No description provided.

@micahgodbolt micahgodbolt self-assigned this Apr 11, 2017
@micahgodbolt
Copy link
Member Author

i.e. create a button variant to support the blue buttons in this shot
image

@stale
Copy link

stale bot commented Apr 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions to Fabric React!

@micahgodbolt micahgodbolt mentioned this issue May 18, 2018
Closed
2 tasks
@micahgodbolt
Copy link
Member Author

My prefered approach to this problem is to make personas able to be buttons and take icons (as to inherit all of the sizes/colors etc)....but right now that's adding a TON of weight to personas. Once buttons get slimmed down we can approach this again.

@micahgodbolt micahgodbolt changed the title Silhouette Button: Create rounded button that takes icon and scales with persona Persona Button: Support personas being rendered as buttons or links Jun 22, 2018
@micahgodbolt
Copy link
Member Author

This might be something we have to put off until we can render a super simple button, or touchabletarget type thing. This approach makes the most sense, but the added weight of our current button is too much.

@micahgodbolt micahgodbolt added this to the Future milestone Aug 6, 2018
@micahgodbolt micahgodbolt added Priority 2: Normal Status: Blocked Resolution blocked by another issue labels Aug 6, 2018
@micahgodbolt
Copy link
Member Author

micahgodbolt commented Aug 6, 2018 •
edited
Loading

Blocked waiting for the #6134 which will hopefully result in a lighter weight persona

@micahgodbolt micahgodbolt removed their assignment Aug 6, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: Persona Needs: Backlog review Status: Blocked Resolution blocked by another issue Type: Feature
Projects
None yet
Milestone
Freezer
Development

Successfully merging a pull request may close this issue.

Added icon option to persona, and added button props to coinProps
4 participants
@mikewheaton @micahgodbolt @khmakoto @JustSlone