Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComboBox: strict mode compliance (UNSAFE_) #14288

Closed
ecraig12345 opened this issue Aug 1, 2020 · 2 comments · Fixed by #14719
Closed

ComboBox: strict mode compliance (UNSAFE_) #14288

ecraig12345 opened this issue Aug 1, 2020 · 2 comments · Fixed by #14719
Assignees

Comments

@ecraig12345
Copy link
Member

ecraig12345 commented Aug 1, 2020

ComboBox updates the following state in componentWillReceiveProps:

  • selectedIndices is reset if props.selectedKeys changes. This can also be set elsewhere in the class (incorrect semi-controlled pattern).
  • currentOptions is reset if props.options changes. This can also be set elsewhere in the class if the user types new options.
  • suggestedDisplayValue is cleared if props.selectedKey is newly null, but can be reset elsewhere in the class

It's likely that this would be easier to fix in-place rather than doing a function component conversion due to the overall complexity of the component.

@microsoft microsoft deleted a comment from msft-github-bot Aug 1, 2020
@ecraig12345 ecraig12345 reopened this Aug 1, 2020
@ecraig12345 ecraig12345 reopened this Aug 1, 2020
@microsoft microsoft deleted a comment from msft-github-bot Aug 1, 2020
@ecraig12345 ecraig12345 changed the title ComboBox: strict mode compliance ComboBox: strict mode compliance (UNSAFE_) Aug 3, 2020
@msft-github-bot msft-github-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Sep 17, 2020
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #14719, which has now been successfully released as @uifabric/[email protected].:tada:

Handy links:

@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #14719, which has now been successfully released as @fluentui/[email protected].:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants