From 0301b3418f69c20819b6582b981c3c32056eb607 Mon Sep 17 00:00:00 2001 From: chassunc <86579954+chassunc@users.noreply.github.com> Date: Thu, 29 Jul 2021 10:37:00 -0300 Subject: [PATCH] fix(DropdownSearchInput): remove wrong aria-labelledby (#19182) * fix(DropdownSearchInput): remove wrong aria-labelledby * remove log * apply proper solution * chore: add changelog --- packages/fluentui/CHANGELOG.md | 1 + .../react-northstar/src/components/Dropdown/Dropdown.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/fluentui/CHANGELOG.md b/packages/fluentui/CHANGELOG.md index 54d07c0a6caba..21c849b1b5e46 100644 --- a/packages/fluentui/CHANGELOG.md +++ b/packages/fluentui/CHANGELOG.md @@ -39,6 +39,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm - Fix `Carousel` glitch in last slide @chassunc ([#19129](https://github.com/microsoft/fluentui/pull/19129)) - Fix `FormTextArea` required styles @chassunc ([#19164](https://github.com/microsoft/fluentui/pull/19164)) - Fix `Button` icon only styles when disabledFocusable @chassunc ([#19180](https://github.com/microsoft/fluentui/pull/19180)) +- Fix `Dropdown` creating unnecessary `aria-labelledby` for `DropdownSearchInput` @chassunc ([#19182](https://github.com/microsoft/fluentui/pull/19182)) ### Features - Add Onyx 600, Silver 100 to color palette and some color tokens @codepretty ([#18827](https://github.com/microsoft/fluentui/pull/18827)) diff --git a/packages/fluentui/react-northstar/src/components/Dropdown/Dropdown.tsx b/packages/fluentui/react-northstar/src/components/Dropdown/Dropdown.tsx index 01de10bbdad46..231354f73bc23 100644 --- a/packages/fluentui/react-northstar/src/components/Dropdown/Dropdown.tsx +++ b/packages/fluentui/react-northstar/src/components/Dropdown/Dropdown.tsx @@ -1125,6 +1125,7 @@ export const Dropdown: ComponentWithAs<'div', DropdownProps> & // https://github.com/facebook/react/issues/955#issuecomment-469352730 setSearchQuery(e.target.value); }, + 'aria-labelledby': null, }), }, // same story as above for getRootProps.