Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the logic to set the java source/target compatibility #187

Closed
jdneo opened this issue Aug 27, 2024 · 1 comment
Closed

Revisit the logic to set the java source/target compatibility #187

jdneo opened this issue Aug 27, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@jdneo
Copy link
Member

jdneo commented Aug 27, 2024

Full context can be found here: redhat-developer/vscode-java#3721

In short, simply check the compilation options may have some issue for some cases, An example is the project in the linked issue.

User can set the source level to 17, and target level to 8. Meanwhile, use [--release, 8] as the compilation arguments. Normally, this should fail during compilation. But the project uses a annotation processor to make it work.

Which says, maybe we should just simply get the source compatibility from the property, not infer it from the compilation options?

@Arthurm1, WDYT?

@jdneo
Copy link
Member Author

jdneo commented Oct 21, 2024

Fixed by #188

@jdneo jdneo closed this as completed Oct 21, 2024
@jdneo jdneo added this to the 0.4.0 milestone Oct 21, 2024
@jdneo jdneo added the bug Something isn't working label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant