Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Null Reference exception when adding empty channel in MS Teams #1522

Closed
VKAlwaysWin opened this issue Jun 11, 2019 · 0 comments · Fixed by #1523
Closed

Null Reference exception when adding empty channel in MS Teams #1522

VKAlwaysWin opened this issue Jun 11, 2019 · 0 comments · Fixed by #1523
Assignees
Labels
Type: Bug Something isn't working

Comments

@VKAlwaysWin
Copy link
Contributor

VKAlwaysWin commented Jun 11, 2019

Name: Issues for IsStartActivity. Example:
https://github.com/microsoft/botframework-solutions/blob/124b9a1c108e1ce854603fb397b411d7d8f30d88/lib/csharp/microsoft.bot.builder.solutions/microsoft.bot.builder.solutions/Extensions/ActivityEx.cs

Language: C#

Description

MembersAdded can be null with ActivityTypes.ConversationUpdate

To Reproduce

1.Install bot to ms teams
2.Use IsActivity extension. For example: turnContext.Activity.IsStartActivity()
3. Create new empty channel.

Expected behavior

No error is thrown.

Screenshots

image

Additional context

Fix can be something like:
if (activity.MembersAdded != null && activity.MembersAdded.Any(m => m.Id == activity.Recipient.Id)) for IsStartActivity method

@VKAlwaysWin VKAlwaysWin added the Type: Bug Something isn't working label Jun 11, 2019
@lauren-mills lauren-mills added the Status: In Progress This work item in underway. label Jun 11, 2019
@lauren-mills lauren-mills removed the Status: In Progress This work item in underway. label Jun 11, 2019
@lauren-mills lauren-mills removed Status: Committed This has been confirmed for the next release. Status: In Progress This work item in underway. Status: Pending Status: Blocked Current progress is blocked labels Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants