Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[Android App] Refactor configuration settings #1395

Closed
ryanisgrig opened this issue May 21, 2019 · 6 comments · Fixed by #1771
Closed

[Android App] Refactor configuration settings #1395

ryanisgrig opened this issue May 21, 2019 · 6 comments · Fixed by #1771
Assignees

Comments

@ryanisgrig
Copy link
Collaborator

ryanisgrig commented May 21, 2019

  1. Merge Bot Configuration & App Configuration together, can add subheaders after if it's too many
  2. Rename settings:
    • Service Key -> Speech Service Subscription Key
    • Service Region -> Speech Service Subscription Key Region
    • Bot Id -> Direct Line Speech Secret Key
    • User ID -> User From Id
    • Remove Voice Name (not used and is set by SSML from VA)
  3. Rename Reset Bot to Restart Conversation
@ryanisgrig ryanisgrig changed the title Add UI configuration settings for brand assets/colors that can be mapped to VA app UI & Adaptive Card host configuration [Android App] Configuration panel for UI settings May 21, 2019
@ryanisgrig ryanisgrig added the Status: Backlog This will go in the product backlog label May 21, 2019
@ryanisgrig
Copy link
Collaborator Author

For the subtle variations of colors, we should consider if we want those customizable as well or just adjust based on the default color.

@abiemann
Copy link
Contributor

let the user edit colors within a host config using a color picker

@ryanisgrig
Copy link
Collaborator Author

There are a couple of approaches for editing the host config that we should consider for it scaling:

  1. User imports their own hostconfig.json into the app, it's settings are reflected throughout cards rendering.
  2. User makes changes in the app for common colors that can reflect through the app & cards themselves. The colors between app resources/card host config are shared variables and reflect a consistent UI throughout the VA experience.

If we use the second approach, should the app inherit host config or vice versa?

It's also important to highlight that we may want to allow for greater configuration like font family. @Dewain27 would we have a need for this?

@abiemann
Copy link
Contributor

inherited from #1441 : allow user to customize the speech-background color

@ryanisgrig ryanisgrig changed the title [Android App] Configuration panel for UI settings [Android App] Refactor configuration settings Jul 8, 2019
@ryanisgrig
Copy link
Collaborator Author

Updated the initial comment to reflect new direction in refactoring configuration

@abiemann
Copy link
Contributor

abiemann commented Jul 8, 2019

also removed directline constant from settings

@lauren-mills lauren-mills removed Status: In Progress This work item in underway. Status: Pending Status: Backlog This will go in the product backlog Status: Committed This has been confirmed for the next release. labels Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants