Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

[botskills] CLI operation should fail if it can't find LU file #1232

Closed
darrenj opened this issue May 2, 2019 · 1 comment
Closed

[botskills] CLI operation should fail if it can't find LU file #1232

darrenj opened this issue May 2, 2019 · 1 comment
Assignees
Labels
Type: Bug Something isn't working

Comments

@darrenj
Copy link
Contributor

darrenj commented May 2, 2019

When --luisFolder is passed to the CLI it uses this to find the LU files. If the CLI can't find the required LU file it should terminate the CLI and not progress.

Right now it continues through the rest of the steps and results in a skill being added but no dispatch intent added for the Skill.

dispatch add --type file --name newsSkill --filePath C:\Users\darrenj\source\repos\4.4\skills\src\csharp\experimental\newsskill\Deployment\Resources\LU\news.luis --intentName newsSkill --dataFolder C:\Users\darrenj\source\repos\build\djvabuilddemo2\djvabuilddemo2\djvabuilddemo2\Deployment\Resources\Dispatch\en --dispatch C:\Users\darrenj\source\repos\build\djvabuilddemo2\djvabuilddemo2\djvabuilddemo2\Deployment\Resources\Dispatch\en\djvabuilddemo2en_Dispatch.dispatch
C:\Users\darrenj\source\repos\4.4\skills\src\csharp\experimental\newsskill\Deployment\Resources\LU\news.luis does not exist.  Please check the file path.
@darrenj darrenj added the Type: Bug Something isn't working label May 2, 2019
@dfavretto
Copy link
Contributor

Thanks for reporting this issue! We actually have a few more in radar, I'll be creating an issue with a list of all known issues for tracking them, so you are aware of what is being work on.

@darrenj darrenj closed this as completed May 5, 2019
@lauren-mills lauren-mills removed Type: Suggestion Status: Committed This has been confirmed for the next release. labels Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants