From c090efaee92d4b61d52ea3580cdd4498a95559b0 Mon Sep 17 00:00:00 2001 From: Ryan Lengel Isgrig <43043272+ryanlengel@users.noreply.github.com> Date: Thu, 20 Jun 2019 09:30:12 +0100 Subject: [PATCH] Proposal for new pull request template (#1594) * Added new template for draft * Update launch plan * change changes text * change launch plan to feature plan --- .github/PULL_REQUEST_TEMPLATE.md | 40 +++++++++++--------------------- 1 file changed, 14 insertions(+), 26 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d845add37b..0fff458f7d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,32 +1,20 @@ - -## Description - +Close #123: Description for this goes here. +--> -### Architecture +## Purpose +*What is the context of this pull request? Why is it being done?* -### Bug Fixes +## Changes +*Are there any changes that need to be called out as significant or particularly difficult to grasp?* -### Conversational Experience +*Include illustrative screenshots for context if applicable.* -### Maintenance +## Tests +*Is this covered by existing tests or new ones? If no, why not?* -### Language Understanding - -## Testing Steps - - -## Checklist - -- [ ] I have commented my code, particularly in hard-to-understand areas -- [ ] I have added or updated the appropriate unit tests -- [ ] I have tested any new/updated dialogs using Speech in the emulator to ensure the [Speak](https://docs.microsoft.com/en-us/azure/bot-service/dotnet/bot-builder-dotnet-text-to-speech?view=azure-bot-service-3.0) property is set to enable a high quality speech-first experience and the appropriate [InputHints](https://docs.microsoft.com/en-us/azure/bot-service/dotnet/bot-builder-dotnet-add-input-hints?view=azure-bot-service-3.0) are set correctly. -- [ ] I have updated related documentation - - -- [ ] A duplicate issue is filed to track future work. - - -- [ ] All languages have been updated -- [ ] You have tested deployment with your new models +## Feature Plan +*Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.* \ No newline at end of file