Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR READY: Add IBotTelemetryClient property into Dialog #5177

Closed
16 tasks
daveta opened this issue Nov 19, 2018 · 1 comment
Closed
16 tasks

PR READY: Add IBotTelemetryClient property into Dialog #5177

daveta opened this issue Nov 19, 2018 · 1 comment

Comments

@daveta
Copy link
Contributor

daveta commented Nov 19, 2018

Reviewed this with @johnataylor (sent mail to @Stevenic / @benbrown with no response yet), @gabog (and VA team), @ryanlengel (@darrenj 's team).

Issue

We need a way to log event data into Waterfall Dialog when:

  • Preceding each step of waterfall
  • When dialog completes (conversion)
  • When dialog cancels.

Proposed change

Add a Logger property onto base Dialog.

Component Impact

Add new IBotTelemetryClient Logger { get; set; } property onto the base Dialog, so developers can access and log custom events from dialogs.
By default, the NullTelemetryClient will be used (no-op).

Customer Impact

No impact on existing SDK clients.

Tracking Status

Dotnet SDK

  • PR
  • Merged

Javascript SDK

  • PR
  • Merged

Java SDK

  • PR
  • Merged

Python SDK

  • PR
  • Merged

Emulator

  • PR
  • Merged

Samples

  • PR
  • Merged

Docs

  • PR
  • Merged

Tools

  • PR
  • Merged

[dcr]

@daveta daveta changed the title DCR: Add IBotTelemetryClient property into Dialog PR READY: Add IBotTelemetryClient property into Dialog Nov 26, 2018
@daveta
Copy link
Contributor Author

daveta commented Nov 27, 2018

Checked in..

@daveta daveta closed this as completed Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant