Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rows Affected Message No Longer Outputted from Query #7322

Closed
chlafreniere opened this issue Sep 23, 2019 · 4 comments
Closed

Rows Affected Message No Longer Outputted from Query #7322

chlafreniere opened this issue Sep 23, 2019 · 4 comments
Assignees
@Charles-Gagnon
Labels
Area - Notebooks Area - Query Editor Bug Impact: DRI
Milestone
November 2019 Rel...

Comments

@chlafreniere
Copy link
Contributor

"(n) Rows Affected" message no longer appears either in the query editor or in notebooks.

This issue is blocking publish for the Insiders build from today, as we have test failures.
@chlafreniere
Copy link
Contributor Author

Looks like this is due to the following commit: 1f61a25

@Charles-Gagnon
Copy link
Contributor

@chlafreniere So this is definitely because of the SqlClient update. The StatementCompleted event isn't being fired. I'm trying to dig into why that's happening - the changes in our code shouldn't have affected that so I'm thinking this might be an actual bug in SqlClient. I'll update if I figure out anything more specific.

@Charles-Gagnon Charles-Gagnon self-assigned this Sep 23, 2019
@chlafreniere chlafreniere added this to the November 2019 Release milestone Sep 23, 2019
@Charles-Gagnon
Copy link
Contributor

Opened dotnet/SqlClient#212 - they're looking into it.

@chlafreniere
Copy link
Contributor Author

#7347 we also need to re-enable these integration tests after a fix comes in from the SqlClient side.

@Charles-Gagnon Charles-Gagnon mentioned this issue Sep 28, 2019
Merged
@adsbot adsbot bot locked and limited conversation to collaborators Nov 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Charles-Gagnon Charles-Gagnon

Labels
Area - Notebooks Area - Query Editor Bug Impact: DRI
Projects
None yet
Milestone
November 2019 Release
Development

No branches or pull requests
3 participants
@kburtram @Charles-Gagnon @chlafreniere