Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 1.7 standalone installation fails #5886

Closed
bschapendonk opened this issue Dec 2, 2015 · 18 comments
Closed

TypeScript 1.7 standalone installation fails #5886

bschapendonk opened this issue Dec 2, 2015 · 18 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@bschapendonk
Copy link

When I try to install TypeScript 1.7 on our build server I get the following error

2015-12-02_123545

We don't have Visual Studio installed on our build server (only the .net sdk and msbuild), this worked with the previous version (1.6)

@IngbertPalm
Copy link

Same problem when installing on a machine with Visual Studio Prof.

Installer is searching for a key 'SOFTWARE\Microsoft\DevDiv\vs\Servicing\14.0\enterprise' which doesn't exists when the Prof. version is installed. No problem with an Enterprise edition.

As workaround I've added the key to the registry. After this I was able to install TS. But now I'm unable to edit ts-files in the VS2015 Update1 Prof IDE. So be careful to use the workaround.

@bschapendonk
Copy link
Author

Afaik the Visual Studio 2015 Update 1 includes TypeScript 1.7, so you shouldn't need to install it

@IngbertPalm
Copy link

Yes it's included. Updating RTM to Update 1 resulted in the same error as in your post.
I assume the same package is used when updating the RTM version of VS or when installing TS as standalone.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 2, 2015

As workaround I've added the key to the registry. After this I was able to install TS. But now I'm unable to edit ts-files in the VS2015 Update1 Prof IDE. So be careful to use the workaround.

@IngbertPalm TS 1.7 have a dependency on Update 1 binaries. if you bypass the check it is going to fail at runtime. the only way to get 1.7 is to install Update1 first. please uninstall TS 1.7, install update1 and then try again.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 2, 2015

@bschapendonk for your build machine, i am assuming it does not have VS installed. if this is the case, use the installer from https://www.microsoft.com/en-us/download/details.aspx?id=48739

@IngbertPalm
Copy link

@mhegazy The problem is that Update 1 failed with the above exception. When I try to reinstall Update 1, the installer tells me that it's already installed. The problem occurred on two different machines with VS 2015 Pro. No problem when applying to an enterprise edition.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 2, 2015

can you share the install logs, you can collect them by running the following tool http://aka.ms/vscollect

@yuit
Copy link
Contributor

yuit commented Dec 2, 2015

@IngbertPalm just to clarify on collecting the logs

  • download the tool from the link: http://aka.ms/vscollect
  • put the exe in your temp folder (%temp%)
  • run the exe. It will produce the logs folder called vslogs.zip.

I will try to find more information in the mean time but the logs will let us know the installation steps in details

@bschapendonk
Copy link
Author

@mhegazy thanks, using the installer for Visual Studio 2013 worked.

@yuit
Copy link
Contributor

yuit commented Dec 3, 2015

@IngbertPalm so just to clarify the issue a bit : the installer looks at the following registry hive for Professional sku SOFTWARE\Microsoft\DevDiv\vs\Servicing\14.0\professional\ for the registry key: UpdateVersion. Do you see the key in your regedit.exe?

From your explanation, I think there is a failure in installing Update1 so the VSUpdate1 installed but not successfully. So TypeScript 1.7 refused to install in your machine. I couldn't repo the issue. However, to get you unblocked, I would suggest you to uninstall the broken installer of VSUpdate1 by : in Control Panel\Programs\Programs and Features on the left-hand side panel you will see View installed updates and there is an entry call "Visual Studio 2015 Update 1 (KB3022398)". Uninstall the exe and try reinstall the VSUpdate1 again.

Let me know if this works out for you.

@IngbertPalm
Copy link

@yuit Thank you for the information. We have reinstalled Visual Studio on both machines and it seems to be OK. Due to this, I think it's needless to provide the logs?

But let me explain the situation which resulted in the issue.
We have two machines with VS 2015 Pro installed and one additional with VS 2015 Enterprise.
I've downloaded the vs2015.1.vsu.iso image from http://www.microsoft.com/en-us/download/details.aspx?id=49989. Updating the Enterprise-Edition with this ISO image was no problem. The update of both VS Pro machines failed with the message that the installer was unable to find Visual Studio 2015 Update 1. In the log-file we found a trace that the TS installer searches for a key SOFTWARE\Microsoft\DevDiv\vs\Servicing\14.0\enterprise. The key doesn't exists when the Pro-Edition is installed. So we have created the key in the registry an used the stand alone installer to install TS. After this, TS was installed on both machines but we were not able to edit TS-files in the IDE.
Finally we have decide to completely uninstall VS 2015 an to reinstall it with the VS 2015 Pro With Update 1 from the MSDN ISO image.

@yuit
Copy link
Contributor

yuit commented Dec 3, 2015

@IngbertPalm I am glad that you are unblock. Thanks for sharing details. Though could you still share your logs? I would like to take a look into what is the root cause of the original issue and see if there is a possible fix for it.

@yuit yuit added Fixed A PR has been merged for this issue Needs More Info The issue still hasn't been fully clarified labels Dec 3, 2015
@mhegazy mhegazy closed this as completed Dec 3, 2015
@soerennielsen
Copy link

How can this issue be closed? I don't see any solution in the thread. @mhegazy ?

The problem is that the standalone typescript installer for the 2015 toolchain cannot install if there is no Visual Studio 2015 with update 1 installed.

Since it is a build server it makes very good sense that no version of visual studio is actually installed (it used to be best practice). So the issue is not really update 1 or not, the issue is that the installer no longer can install on a machine without visual studio 2015 - not the sidetracked disccusion about failed installations of update 1.

The 2013 package can and the previous versions for 2015 could also without visual studio.

Installing the 2013 package fixes the issue for the builds using toolsversion 12 (aka 2013), but not 14 (aka 2015).
Anyone have a workaround?

(Note that I tried with versoin 1.7.6)

@mhegazy mhegazy added Bug A bug in TypeScript and removed Fixed A PR has been merged for this issue Needs More Info The issue still hasn't been fully clarified labels Jan 4, 2016
@mhegazy mhegazy added this to the TypeScript 1.8 milestone Jan 4, 2016
@mhegazy mhegazy reopened this Jan 4, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Jan 4, 2016

reopening. the 2015 targets will not be installed. we will need to publish a standalone version or augment the check to check from both VS 2015, and VS2015 update1.

@mhegazy
Copy link
Contributor

mhegazy commented Jan 4, 2016

Another possible workaround, is to use the the nuget package: #3940 (comment) this one does not require any installation

@soerennielsen
Copy link

I've been battling that for a while, but as soon as had written the bits above I found a possible workaround:

  1. Install the 2013 version (which installs the actual compiler and the msbuild target files for 2013)
  2. Copy the content from "C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0" from a a dev machine (with everything installed) to the same location on the build server.

Seems to work.

@MoonStorm
Copy link

Just installed MS Build Tools 2015 and the Windows SDK on our TeamCity build server, which should have been enough for the standalone installer to work. It doesn't. It stops with the error mentioned in the first post.

I couldn't find the "VS 2015 Update 1" equivalent for the build tools. What am I missing here?

@mhegazy mhegazy assigned paulvanbrenk and unassigned yuit Jan 27, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 27, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Jan 27, 2016

Should be fixed in the next release.

@mhegazy mhegazy closed this as completed Jan 27, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

7 participants