Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message, related spans, for incompatible overloads #30026

Closed
DanielRosenwasser opened this issue Feb 21, 2019 · 0 comments
Closed

Better error message, related spans, for incompatible overloads #30026

DanielRosenwasser opened this issue Feb 21, 2019 · 0 comments
Assignees
@DanielRosenwasser
Labels
Domain: Error Messages The issue relates to error messaging Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Experience Enhancement Noncontroversial enhancements Fixed A PR has been merged for this issue
Milestone
TypeScript 3.4.0

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Feb 21, 2019 •
edited
Loading

Today:

Overload signature is not compatible with function implementation.

This is unnecessarily terse, and is unhelpful for users who might not be familiar with our terminology.

Proposed:

Overload signature is not compatible with function implementation.

  The implementation signature is declared here.

Sub-item of #22789.
@DanielRosenwasser DanielRosenwasser added Domain: Error Messages The issue relates to error messaging Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Experience Enhancement Noncontroversial enhancements labels Feb 21, 2019
@DanielRosenwasser DanielRosenwasser self-assigned this Feb 21, 2019
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.4.0 milestone Feb 21, 2019
@DanielRosenwasser DanielRosenwasser mentioned this issue Feb 21, 2019
Merged
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Domain: Error Messages The issue relates to error messaging Domain: Related Error Spans Specifying regions for error messages/diagnostics on multiple locations. Experience Enhancement Noncontroversial enhancements Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 3.4.0
Development

No branches or pull requests
1 participant
@DanielRosenwasser