Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--showConfig is ignoring missing extends file #28598

Closed
vvakame opened this issue Nov 19, 2018 · 2 comments
Closed

--showConfig is ignoring missing extends file #28598

vvakame opened this issue Nov 19, 2018 · 2 comments
Labels
Experience Enhancement Noncontroversial enhancements Fixed A PR has been merged for this issue

Comments

@vvakame
Copy link
Contributor

vvakame commented Nov 19, 2018

TypeScript Version: 3.2.0-dev.20181117

and local build with 608a830

Search Terms:
showConfig

Code

{
  "extends": "./notExists.tsconfig.json",
  "compilerOptions": {
    "target": "esnext",
    "module": "commonjs",
    "strict": true
  }
}

Expected behavior:
show error TS5058: The specified path does not exist: '/foobar/notExists.tsconfig.json'. error message.

Actual behavior:
don't report any error and dump incompleteness config value.

Playground Link: None

Related Issues: #27353

I made a patch to this issue.
If this is a problem, I can submit this patch.
vvakame@d6d9c9e

@weswigham
Copy link
Member

I've gone back and forth on this - the diagnostics are obviously useful for fixing the config; however then you can't rely on the output with the flag on always being JSON. Then again, the return code changes when diagnostics are emitted, so that might be fine...

@vvakame I think we'll take a PR for the change, but the JSON document and the diagnostics should be either/or - meaning if there are diagnostics for the config file, we print those, rather than the config. I think that's probably the way to go.

@vvakame
Copy link
Contributor Author

vvakame commented Nov 20, 2018

@weswigham thanks! I made a PR #28612 😉

@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Dec 8, 2018
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.3 milestone Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience Enhancement Noncontroversial enhancements Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants