Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support completion details for string literal completions #21374

Closed
ghost opened this issue Jan 23, 2018 · 0 comments
Closed

Support completion details for string literal completions #21374

ghost opened this issue Jan 23, 2018 · 0 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@ghost
Copy link

ghost commented Jan 23, 2018

TypeScript Version: 2.7.0-dev.20180123

Search Terms: string completion details

Code

/// <reference path="fourslash.ts" />

////const x: "a" = "/**/";

goTo.marker();
verify.completionListContains("a", "text", "doc", "kind", undefined, undefined);

Expected behavior:

Successfully get completion details.

Actual behavior:

NPE because getCompletionEntryDetails returns undefined.

@ghost ghost added the Bug A bug in TypeScript label Jan 23, 2018
@ghost ghost self-assigned this Jan 23, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Jan 24, 2018
@mhegazy mhegazy modified the milestones: TypeScript 2.8, TypeScript 2.9 Mar 9, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 27, 2018
@ghost ghost closed this as completed in #22664 Mar 28, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

1 participant