Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThisType<T> isn't respected under the --strict master option #14521

Closed
DanielRosenwasser opened this issue Mar 7, 2017 · 1 comment
Closed
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Mar 7, 2017

Because the check uses compilerOptions instead of the noImplicitThis variable. 😉

Run the following example with --strict:

let x: ThisType<String> = {
    bar() {
        this.toLowerCase();
    }
}

Expected: No error
Actual: Implicit any error on this.

@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Mar 7, 2017
@ahejlsberg
Copy link
Member

Already fixed in #14510.

@ahejlsberg ahejlsberg added the Fixed A PR has been merged for this issue label Mar 8, 2017
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

2 participants