Skip to content

Commit 2a99ca9

Browse files
author
Andy Hanson
committed
Avoid growing toDo too eagerly
1 parent c0b159a commit 2a99ca9

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

src/server/session.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -363,14 +363,18 @@ namespace ts.server {
363363

364364
while (toDo.length) {
365365
const { project, location } = Debug.assertDefined(toDo.pop());
366-
if (project.getCancellationToken().isCancellationRequested() || !addToSeen(seenProjects, project.projectName)) continue;
366+
if (project.getCancellationToken().isCancellationRequested()) continue;
367367
cb({ project, location }, (project, location) => {
368368
const originalLocation = project.getSourceMapper().tryGetOriginalLocation(location);
369369
const originalProject = originalLocation && projectService.getProjectForFileWithoutOpening(toNormalizedPath(originalLocation.fileName));
370-
if (originalProject) toDo.push({ project: originalProject, location: originalLocation! });
370+
if (originalProject) addToTodo({ project: originalProject, location: originalLocation! });
371371
return !!originalProject;
372372
});
373373
}
374+
375+
function addToTodo(projectAndLocation: ProjectAndLocation): void {
376+
if (addToSeen(seenProjects, projectAndLocation.project.projectName)) toDo.push(projectAndLocation);
377+
}
374378
}
375379

376380
function documentSpanLocation({ fileName, textSpan }: DocumentSpan): sourcemaps.SourceMappableLocation {

0 commit comments

Comments
 (0)